Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized away the expensive StringBuilder.Remove(0, 1) in CodeInlineParser #418

Merged
merged 2 commits into from
Apr 18, 2020
Merged

Optimized away the expensive StringBuilder.Remove(0, 1) in CodeInlineParser #418

merged 2 commits into from
Apr 18, 2020

Conversation

KrisVandermotten
Copy link
Contributor

No description provided.

MihaZupan
MihaZupan approved these changes Apr 13, 2020
View reviewed changes
Copy link
Collaborator

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! idk how I missed that StringBuilder has this ToString overload

@xoofx
Copy link
Owner

xoofx commented Apr 18, 2020

Sorry, the CI on master was broken and it should be fixed now. Could you rebase/merge master to your branch please? Thanks!

@xoofx xoofx merged commit 0386cfd into xoofx:master Apr 18, 2020
@xoofx
Copy link
Owner

xoofx commented Apr 18, 2020

Thanks!

@KrisVandermotten KrisVandermotten deleted the CodeInlineParser branch April 18, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrisVandermotten @xoofx @MihaZupan